refactor(system/mrm_comfortable_stop_operator): rework parameters #5733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:system
karishma1911
force-pushed
the
mrm-comfortable-stop-operator
branch
from
5cd23c8 to
9dad0f1
Compare
Signed-off-by: karishma <[email protected]>
Signed-off-by: karishma <[email protected]>
karishma1911
force-pushed
the
mrm-comfortable-stop-operator
branch
from
2cb3982 to
9f92d7d
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
@mkuri @TomohitoAndo please urgently review this PR. |
|
@mkuri could you confirm if it is okay to remove the default parameters from the cpp file? We have decided this in the AWF to avoid using hard coded parameters in order to force everyone to set parameters from parameter files. |
|
Any updates about this PR @mitsudome-r @mkuri ? |
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
@mitsudome-r We need to assign someone else to finish this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the mrm_comfortable_stop_operator
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.